Repository navigation
Conversation
…ction id nullable
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds MONETA, built on #30. No real MONETA e-mail has been seen: the template follows the sanitised samples in radekhulan/myinvoice (MIT), whose parser real users run. The fixtures are synthetic and say so.
Safe until a real e-mail comes:
KEY_FINGERPRINTSis empty, and an empty pin set now refuses every key with "no key is pinned for moneta.cz yet" plus the fingerprint DNS gave, sowithDns()treats every MONETA e-mail asUnverified. Pinning that fingerprint, after checking it, is the step left.What MONETA's e-mail does not carry, and what that changes in the interface:
Transaction.account()is nullable, documented as null for MONETA, which masks it (238***891). The merchant has to be known from the inbound address.Transaction.transactionId()is nullable, null for MONETA, which prints none; deduplicate on a signedmessageId()(be: hand out the message-id when the bank signs it, for banks with no transaction id #30).Popis, which may hold the payer's text, so twoVS:there are refused and the docs say to match on the amount too.type()GENERAL, onlyKčamounts.NotificationLines.stackedreads a label alone on a line with its value on the next one, through the same duplicate and after-the-message guards aslabelled. The tests cover a forgedČástkaafterPopis, two symbols, a heading against the subject, another currency, and the no-pin refusal.make build: green.